dell/xps/13-9360: review

common/cpu/intel/kaby-lake/default.nix

@@ -0,0 +1,8 @@
+{
+  imports = [ ../. ];
+
+  kernelParams = [
+    "i915.enable_fbc=1"
+    "i915.enable_psr=2"
+  ];
+}

dell/xps/13-9360/default.nix

@@ -1,42 +1,26 @@
 { lib, pkgs, ... }:
-let
+
-  firmware_qca6174 = pkgs.callPackage ./firmware_qca6174.nix {};
-in
 {
   imports = [
-    ../../../common/cpu/intel
+    ../../../common/cpu/intel/kaby-lake
     ../../../common/pc/laptop
   ];
-  boot.kernelModules = ["kvm-intel"]; # should this be in common/cpu/intel?
-  boot = {
-    loader = {
-      systemd-boot.enable = lib.mkDefault true;
-      efi.canTouchEfiVariables = lib.mkDefault true;
-    };
 
-    kernelPackages = lib.mkDefault pkgs.linuxPackages_latest;
+  boot.blacklistedKernelModules = [ "psmouse" ]; # touchpad goes over i2c
-    initrd.availableKernelModules = [ "xhci_pci" "nvme" "usb_storage" "sd_mod" "rtsx_pci_sdmmc" ];
-    # touchpad goes over i2c
-    blacklistedKernelModules = [ "psmouse" ];
 
-    kernelParams = [ "i915.enable_fbc=1" "i915.enable_psr=2" ];
+  # TODO: decide on boot loader policy
+  boot.loader = {
+    efi.canTouchEfiVariables = lib.mkDefault true;
+    systemd-boot.enable = lib.mkDefault true;
   };
   
-  # intel huc, guc. qca6174 (old?)
+  hardware.firmware = lib.mkBefore [ pkgs.qca6174-firmware ];
-  hardware.enableRedistributableFirmware = true;
 
-  # 4k screen, use bigger console font
+  # TODO: move to general HiDPI profile
-  i18n.consoleFont = "latarcyrheb-sun32";
+  i18n.consoleFont = lib.mkDefault "latarcyrheb-sun32"; # 4K screen, use bigger console font
-
-  # touchpad
-  services.xserver.libinput.enable = lib.mkDefault true;
-
-  networking.wireless.enable = lib.mkDefault true;
-  hardware.bluetooth.enable = lib.mkDefault true;
-  
-  services.thermald.enable = lib.mkDefault true;
-
-  # optional: without it, firmware crashes happened
-  hardware.firmware = lib.mkBefore [ firmware_qca6174 ];
 
+  # TODO: upstream to NixOS/nixpkgs
+  nixpkgs.overlays = [(final: previous: {
+    qca6174-firmware = final.callPackage ./qca6174-firmware.nix {};
+  })];
 }

dell/xps/13-9360/qca6174-firmware.nix

@@ -1,22 +1,26 @@
-{ stdenv, fetchurl  }:
+{ stdenv, fetchurl }:
 
 stdenv.mkDerivation rec {
-  target = "QCA6174";
-  branch = "4.4.1.c1";
-  version = "${branch}-00042";
   name = "${target}-firmware-${version}";
+  version = "${branch}-00042";
+
+  branch = "4.4.1.c1";
+  target = "QCA6174";
+
   src = fetchurl {
     url = "https://github.com/kvalo/ath10k-firmware/raw/master/${target}/hw3.0/${branch}/firmware-6.bin_RM.${version}-QCARMSWP-1";
     sha256 = "01vvz3qhqw5l3yilcqgk1spk4y9k4qy7na7a57cbl037r231szdh";
   };
+
   buildCommand = ''
     install -D $src $out/lib/firmware/ath10k/${target}/hw3.0/firmware-6.bin
   '';
+
   meta = with stdenv.lib; {
-    license = with licenses; unfreeRedistributable;
-    homepage = "https://github.com/kvalo/ath10k-firmware/tree/master/QCA6174/hw3.0";
     description = "Updated firmware for the qca6174 wireless chip";
-    platforms = with platforms; linux;
+    homepage = "https://github.com/kvalo/ath10k-firmware/tree/master/QCA6174/hw3.0";
+    license = licenses.unfreeRedistributable;
     maintainers = with maintainers; [ yorickvp ];
+    platforms = platforms.linux;
   };
 }