From b371da6e8da2875169898773203ede9117cb5ba7 Mon Sep 17 00:00:00 2001 From: Ivan Kovnatsky Date: Tue, 1 Dec 2020 14:42:01 +0200 Subject: [PATCH] apple/macbook-pro/12-1: brcmfmac: mention resume issue --- apple/macbook-pro/12-1/default.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apple/macbook-pro/12-1/default.nix b/apple/macbook-pro/12-1/default.nix index f9dff3b..a28ea82 100644 --- a/apple/macbook-pro/12-1/default.nix +++ b/apple/macbook-pro/12-1/default.nix @@ -8,12 +8,13 @@ ]; powerManagement = { - # enable gradually increasing/decreasing CPU frequency, rather than using + # Enable gradually increasing/decreasing CPU frequency, rather than using # "powersave", which would keep CPU frequency at 0.8GHz. cpuFreqGovernor = lib.mkDefault "conservative"; # brcmfmac being loaded during hibernation would not let a successful resume - # https://bugzilla.kernel.org/show_bug.cgi?id=101681#c116 + # https://bugzilla.kernel.org/show_bug.cgi?id=101681#c116. + # Also brcmfmac could randomly crash on resume from sleep. powerUpCommands = lib.mkBefore "${pkgs.kmod}/bin/modprobe brcmfmac"; powerDownCommands = lib.mkBefore "${pkgs.kmod}/bin/rmmod brcmfmac"; };