From 346c13e609824865c00cf45a58796d8f214a8e9e Mon Sep 17 00:00:00 2001
From: Nelson Jeppesen <50854675+NelsonJeppesen@users.noreply.github.com>
Date: Sat, 8 Jan 2022 18:54:11 -0800
Subject: [PATCH] add xps 17 9710

---
 README.md                          |  1 +
 dell/xps/17-9710/README.wiki       | 44 ++++++++++++++++++++++++++++++
 dell/xps/17-9710/intel/README.wiki |  1 +
 dell/xps/17-9710/intel/default.nix | 13 +++++++++
 flake.nix                          |  1 +
 5 files changed, 60 insertions(+)
 create mode 100644 dell/xps/17-9710/README.wiki
 create mode 120000 dell/xps/17-9710/intel/README.wiki
 create mode 100644 dell/xps/17-9710/intel/default.nix

diff --git a/README.md b/README.md
index f974d92..c89c34f 100644
--- a/README.md
+++ b/README.md
@@ -99,6 +99,7 @@ See code for all available configurations.
 | [Dell XPS 15 9560, nvidia only](dell/xps/15-9560/nvidia)            | `<nixos-hardware/dell/xps/15-9560/nvidia>`         |
 | [Dell XPS 15 9500](dell/xps/15-9500)                                | `<nixos-hardware/dell/xps/15-9500>`                |
 | [Dell XPS 15 9500, nvidia](dell/xps/15-9500/nvidia)                 | `<nixos-hardware/dell/xps/15-9500/nvidia>`         |
+| [Dell XPS 17 9710, intel only](dell/xps/17-9710/intel)              | `<nixos-hardware/dell/xps/17-9710/intel>`          |
 | [FriendlyARM NanoPC-T4](friendlyarm/nanopc-t4)                      | `<nixos-hardware/friendlyarm/nanopc-t4>`           |
 | [Google Pixelbook](google/pixelbook)                                | `<nixos-hardware/google/pixelbook>`                |
 | [GPD MicroPC](gpd/micropc)                                          | `<nixos-hardware/gpd/micropc>`                     |
diff --git a/dell/xps/17-9710/README.wiki b/dell/xps/17-9710/README.wiki
new file mode 100644
index 0000000..e46168e
--- /dev/null
+++ b/dell/xps/17-9710/README.wiki
@@ -0,0 +1,44 @@
+= Dell XPS 17 9710 =
+
+There are two major hardware variants. Intel-only and NVidia
+
+This has only been tested with the Intel-only variant
+
+== Firmware Configuration ==
+
+Enter the bios by repeatedly pressing F2 when the laptop turns on
+
+=== Before installation ===
+
+These settings are needed both for booting the final install, and installer itself. Therefore, they must be done first.
+
+==== Method One ====
+
+* Click ''Restore Settings'' button a select ''BIOS Defaults'', not to be confused with ''Factory Settings''
+
+==== Method Two ====
+
+* ''Disable Secure Boot (but keep UEFI Boot).'' Thankfully doing so is as easy as changing any other simple setting.
+
+* ''Disable Intel hardware RAID and use AHCI instead.'' Intel doesn't seem to provide a working linux driver for this
+
+== Optional ==
+
+=== Firmware upgrades ===
+
+Note that this device is supported by [https://fwupd.org/ fwupd].
+To perform firmware upgrades just activate the service
+
+<code>
+services.fwupd.enable = true;
+</code>
+
+Then use <code>fwupdmgr</code> to perform updates.
+
+=== Enable fingerprint reader ===
+
+Activate the service
+
+<code>
+services.fprintd.enable = true;
+</code>
diff --git a/dell/xps/17-9710/intel/README.wiki b/dell/xps/17-9710/intel/README.wiki
new file mode 120000
index 0000000..4ba8dc7
--- /dev/null
+++ b/dell/xps/17-9710/intel/README.wiki
@@ -0,0 +1 @@
+../README.wiki
\ No newline at end of file
diff --git a/dell/xps/17-9710/intel/default.nix b/dell/xps/17-9710/intel/default.nix
new file mode 100644
index 0000000..b07c609
--- /dev/null
+++ b/dell/xps/17-9710/intel/default.nix
@@ -0,0 +1,13 @@
+{ lib, pkgs, ... }: {
+  imports = [
+    ../../../../common/cpu/intel
+    ../../../../common/pc/laptop
+    ../../../../common/pc/ssd
+  ];
+
+  # Includes the Wi-Fi and Bluetooth firmware
+  hardware.enableRedistributableFirmware = true;
+
+  # Requires at least 5.12 for working sound
+  boot.kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "5.12") (lib.mkDefault pkgs.linuxPackages_latest);
+}
diff --git a/flake.nix b/flake.nix
index f1eaf50..c7662c5 100644
--- a/flake.nix
+++ b/flake.nix
@@ -35,6 +35,7 @@
       dell-xps-15-9560-nvidia = import ./dell/xps/15-9560/nvidia;
       dell-xps-15-9500 = import ./dell/xps/15-9500;
       dell-xps-15-9500-nvidia = import ./dell/xps/15-9500/nvidia;
+      dell-xps-17-9710-intel = import ./dell/xps/17-9710/intel;
       friendlyarm-nanopc-t4 = import ./friendlyarm/nanopc-t4;
       google-pixelbook = import ./google/pixelbook;
       gpd-micropc = import ./gpd/micropc;