From f752581d6723a10da7dfe843e917a3b5e4d8115a Mon Sep 17 00:00:00 2001
From: Keanu Kerr <keanu@kerr.us>
Date: Mon, 1 Jan 2024 13:19:05 +0100
Subject: [PATCH] Added file for HP EliteBook 845 G8 and updated flake and
 README

---
 README.md                       |  1 +
 flake.nix                       |  1 +
 hp/elitebook/845/g8/default.nix | 25 +++++++++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 hp/elitebook/845/g8/default.nix

diff --git a/README.md b/README.md
index d8aae45..b8e45bb 100644
--- a/README.md
+++ b/README.md
@@ -147,6 +147,7 @@ See code for all available configurations.
 | [Google Pixelbook](google/pixelbook)                                   | `<nixos-hardware/google/pixelbook>`                     |
 | [HP Elitebook 2560p](hp/elitebook/2560p)                               | `<nixos-hardware/hp/elitebook/2560p>`                   |
 | [HP Elitebook 845g7](hp/elitebook/845/g7)                              | `<nixos-hardware/hp/elitebook/845/g7>`                  |
+| [HP Elitebook 845g8](hp/elitebook/845/g8)                              | `<nixos-hardware/hp/elitebook/845/g8>`                  |
 | [HP Elitebook 845g9](hp/elitebook/845/g9)                              | `<nixos-hardware/hp/elitebook/845/g9>`                  |
 | [HP Notebook 14-df0023](hp/notebook/14-df0023)                         | `<nixos-hardware/hp/notebook/14-df0023>`                |
 | [i.MX8QuadMax Multisensory Enablement Kit](nxp/imx8qm-mek/)            | `<nixos-hardware/nxp/imx8qm-mek>`                       |
diff --git a/flake.nix b/flake.nix
index f29c9a7..4d44aa2 100644
--- a/flake.nix
+++ b/flake.nix
@@ -82,6 +82,7 @@
       gpd-win-max-2-2023 = import ./gpd/win-max-2/2023;
       hp-elitebook-2560p = import ./hp/elitebook/2560p;
       hp-elitebook-845g7 = import ./hp/elitebook/845/g7;
+      hp-elitebook-845g8 = import ./hp/elitebook/845/g8;
       hp-elitebook-845g9 = import ./hp/elitebook/845/g9;
       hp-notebook-14-df0023 = import ./hp/notebook/14-df0023;
       intel-nuc-8i7beh = import ./intel/nuc/8i7beh;
diff --git a/hp/elitebook/845/g8/default.nix b/hp/elitebook/845/g8/default.nix
new file mode 100644
index 0000000..60afe6a
--- /dev/null
+++ b/hp/elitebook/845/g8/default.nix
@@ -0,0 +1,25 @@
+{ pkgs, lib, ... }:
+
+{
+  imports =
+    [
+      ../../../../common/cpu/amd
+      ../../../../common/cpu/amd/pstate.nix
+      ../../../../common/gpu/amd
+      ../../../../common/pc/laptop
+      ../../../../common/pc/laptop/acpi_call.nix
+      ../../../../common/pc/laptop/ssd
+    ];
+
+  hardware.enableRedistributableFirmware = lib.mkDefault true;
+  boot.kernelModules = [ "synaptics_usb" ];
+  boot.kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "6.3") (lib.mkDefault pkgs.linuxPackages_latest);
+
+  # disable Scatter/Gather APU recently enabled by default,
+  # which results in white screen after display reconfiguration
+  boot.kernelParams = [ "amdgpu.sg_display=0" ];
+
+  services.xserver = {
+    videoDrivers = [ "amdgpu" ];
+  };
+}