Commit graph

10 commits

Author SHA1 Message Date
Thiago Kenji Okada 9194b8e949 nvidia: remove -a flag from exec
The `-a` from exec sets the `$0` from the process. So `exec -a "$0"`
would set the name of the new process to `nvidia-offload` (the name of
the script), however this is causing issues with a few programs that try
to interpret `$0` in a special way. For example, see `wine`:

```
$ nvidia-offload /nix/store/zhv91s26gsrl1w8yn9800xd03a31r3wj-wine-osu-7.0/bin/wine .osu/drive_c/osu/osu\!.exe
/nix/store/zhv91s26gsrl1w8yn9800xd03a31r3wj-wine-osu-7.0/bin/nvidia-offload: could not open
```

What I think `wine` is doing here is trying to re-exec `wine` again, but
to do so it tries to figure out the original call of wine by readind `$0`,
and will fail in this case because the `$0` was changed because of the
`nvidia-offload` script using `-a` flag, as explained above.

Instead, let's simplify this. There is no good reason to rename the `$0`
from the script anyway (it just sets a few environment variables), so let's
just remove it. We may lose the ability to know if the command is being
offloaded, but I think having more commands to work is a good trade-off.
2022-06-24 23:45:31 +01:00
Bruno Bigras 53b470587f split CPU and GPU from common/cpu/intel
fix #388
2022-04-12 11:08:50 -04:00
Martino Fontana abd470874b AMD: Prefer RADV 2022-03-16 17:09:08 +01:00
Nicholas Sielicki 478cc4aa6e make comment more clear that it applies to all igpus, not just intel 2022-03-06 19:25:42 +00:00
Johannes Arnold a57fc74bc3 AMD: include 32-bit driver for Vulkan 2021-09-28 20:14:53 +02:00
Thiago Kenji Okada b0f31689ac Remove intel drivers from nvidia-disable
Two reasons for this change:
- `intel` drivers are not updated from quite a long time (since ~2019),
  and `modesetting` is the preferred one for Intel iGPUs.
- Technically you may want to disable NVIDIA GPUs on laptops with AMD
  processors too.

We don't want to pin `modesetting` here because it is already the default
since PR: https://github.com/NixOS/nixpkgs/pull/111551.
2021-06-11 17:04:10 -03:00
Johannes Arnold 40ddf363c2 Document driver choice 2021-04-14 16:18:05 +02:00
Johannes Arnold f2b2ae018d AMD: add configurations for graphics cards 2021-03-24 02:18:03 +01:00
Thiago Kenji Okada 36094450fd Add nvidia-disable profile
This is already used in XPS 15-9560, but instead of defining it in XPS
15-9560 let's create a separate profile and expose it for those who want
to disable their NVIDIA GPU.
2021-02-28 13:51:46 -03:00
bahaynes b7a5f1188f
Moved NVIDIA config to common, and updated README. 2020-07-25 23:53:47 -04:00